Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Undo/redo history is lost on rotate #377

Closed
hypest opened this issue Dec 13, 2018 · 4 comments
Closed

[Android] Undo/redo history is lost on rotate #377

hypest opened this issue Dec 13, 2018 · 4 comments
Assignees
@hypest
Labels
App Integration [OS] Android [Type] Bug Something isn't working
Projects
Mobile Gutenberg (Archive. Use https:...
Milestone
Beta

Comments

@hypest
Copy link
Contributor

hypest commented Dec 13, 2018

Rotating the device while having some content changed seems to lose the undo/redo history.

Steps to reproduce:

  1. Use wpandroid
  2. Open a in gutenberg-mobile and do some minor changes to the content. Verify that undo/redo are working fine.
  3. Rotate the device. Notice that the undo/redo buttons are disabled
@hypest hypest added this to the Alpha milestone Dec 13, 2018
@koke
Copy link
Member

koke commented Dec 13, 2018

Related to wordpress-mobile/WordPress-Android#8739 (comment) ?

@hypest
Copy link
Contributor Author

hypest commented Dec 13, 2018

Related to wordpress-mobile/WordPress-Android#8739 (comment) ?

Not really but related to rotation in general.

In this case, because we don't actually keep (all of) the RN app's state, undo/redo is just lost on rotation even if we do reinstate the content.

@marecar3 marecar3 self-assigned this Dec 17, 2018
@mzorz mzorz mentioned this issue Dec 17, 2018
Closed
1 task
@marecar3 marecar3 removed their assignment Dec 18, 2018
@mzorz mzorz removed their assignment Dec 18, 2018
@mzorz
Copy link
Contributor

mzorz commented Dec 18, 2018 •
edited

Moving to Beta and unassigning it for now as per the following wordpress-mobile/WordPress-Android#8800 (comment)

@etoledom etoledom added [Type] Bug Something isn't working [OS] Android labels Dec 21, 2018
@mzorz mzorz self-assigned this Dec 21, 2018
@mzorz mzorz mentioned this issue Dec 26, 2018
Closed
13 tasks
@koke koke modified the milestones: Alpha, Beta Jan 15, 2019
@mzorz mzorz removed their assignment Jan 16, 2019
@hypest hypest mentioned this issue Jan 21, 2019
Merged
1 task
@hypest hypest moved this from Sprint #23 (Jan 14 → Jan 25) to In progress in Mobile Gutenberg (Archive. Use https://github.com/orgs/wordpress-mobile/projects/43) Jan 24, 2019
@mzorz
Copy link
Contributor

mzorz commented Feb 28, 2019

Closed in #9030

@mzorz mzorz closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hypest hypest

Labels
App Integration [OS] Android [Type] Bug Something isn't working
Projects
No open projects
Mobile Gutenberg (Archive. Use https:...
Done
Milestone
Beta
Development

No branches or pull requests
5 participants
@koke @hypest @mzorz @etoledom @marecar3