Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken window: missing side padding on extra block options bottomsheet #4261

Open
hypest opened this issue Nov 19, 2021 · 0 comments
Open

Broken window: missing side padding on extra block options bottomsheet #4261

hypest opened this issue Nov 19, 2021 · 0 comments
Labels
[Pri] Low [Type] Enhancement Improves a current area of the editor

Comments

@hypest
Copy link
Contributor

hypest commented Nov 19, 2021

Describe the bug
The text button options offered by the 3-dot block settings bottom sheet do not have padding on the left and right side, making them look "off" when tapped on. The space left and right of the text buttons is not too big anyway so I don't think there's a usability issue due to the missing padding, and that's why I'd consider this a (visual) broken window.

To Reproduce
Steps to reproduce the behavior:

  1. On the Android demo app, add a block and hit the 3-dot/ellipsis button to open the block options
  2. Tap and hold any of the offered options, for example hold the "Copy block" option
  3. Notice that there's no highlight applied to the left and the right of the textual button, an indication that side padding is minimal or zero.

Expected behavior
Some padding should be there on the left and right as well, to give better visual balance when tapped on.

Screenshots

Smartphone (please complete the following information):

  • Device: Pixel 2XL
  • OS: Android 11
  • Version WPAndroid v18.7-rc-2
@hypest hypest added [Type] Enhancement Improves a current area of the editor [Pri] Low labels Nov 19, 2021
@hypest hypest added this to Triage in Mobile Gutenberg via automation Nov 19, 2021
@hypest hypest moved this from Triage to Backlog (unscheduled/unassigned) in Mobile Gutenberg Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Low [Type] Enhancement Improves a current area of the editor
Projects
Mobile Gutenberg
  
Backlog (unscheduled/unassigned)
Development

No branches or pull requests

1 participant