Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNAztecView does not pass validation #5922

Open
mokagio opened this issue Jul 3, 2023 · 1 comment
Open

RNAztecView does not pass validation #5922

mokagio opened this issue Jul 3, 2023 · 1 comment

Comments

@mokagio
Copy link
Contributor

mokagio commented Jul 3, 2023

Initially, I thought this was a problem due to the ongoing 0.71.11 upgrade work, (see e.g. #5912), but I was able to verify on trunk, too.

In particular, we get - ERROR | xcodebuild: /path/to/gutenberg-mobile/gutenberg/packages/react-native-aztec/ios/RNTAztecView/RCTAztecView-Bridging-Header.h:5:9: error: 'React/RCTEventEmitter.h' file not found.

I don't think this is a blocker, but I'd be interesting to dig into why that's happening.

My first guess would be that the error occurs when working with the pod in isolation from its spec, but that once the pod is fetched together with all the other React Native dependencies, that file can be found.

Full log:

➜ bunble exec pod lib lint ../RNTAztecView.podspec --no-clean

 -> RNTAztecView (1.98.1)
    - WARN  | attributes: Missing required attribute `license`.
    - WARN  | license: Missing license type.
    - WARN  | source: Git sources should specify a tag.
    - ERROR | [iOS] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | xcodebuild:  note: Using codesigning identity override: -
    - NOTE  | [iOS] xcodebuild:  note: Building targets in dependency order
    - NOTE  | [iOS] xcodebuild:  note: Metadata extraction skipped. No AppIntents.framework dependency found. (in target 'React-Core' from project 'Pods')
    - NOTE  | xcodebuild:  <module-includes>:1:9: note: in file included from <module-includes>:1:
    - NOTE  | xcodebuild:  //privateTarget Support Files/RNTAztecView/RNTAztecView-umbrella.h:13:9: note: in file included from //privateTarget Support Files/RNTAztecView/RNTAztecView-umbrella.h:13:
    - ERROR | xcodebuild:  /Users/gio/Developer/a8c/gutenberg-mobile/gutenberg/packages/react-native-aztec/ios/RNTAztecView/RCTAztecView-Bridging-Header.h:5:9: error: 'React/RCTEventEmitter.h' file not found
    - NOTE  | xcodebuild:  <unknown>:0: error: could not build Objective-C module 'RNTAztecView'

Pods workspace available at `/var/folders/dq/cdqxvx3s5ps75564rpmb_dc00000gn/T/CocoaPods-Lint-20230703-1656-116vv3o-RNTAztecView/App.xcworkspace` for inspection.

[!] RNTAztecView did not pass validation, due to 2 errors and 3 warnings.
@mokagio
Copy link
Contributor Author

mokagio commented Jul 3, 2023

For what is worth, Gutenberg.podspec also fails in a way related to the React-Core library:

➜ be pod lib lint ../Gutenberg.podspec --no-clean

 -> Gutenberg (1.98.1)
    - WARN  | attributes: Missing required attribute `license`.
    - WARN  | license: Missing license type.
    - WARN  | source: Git sources should specify a tag.
    - ERROR | [iOS] unknown: Encountered an unknown error (Unable to find a specification for `React-CoreModules (= 0.69.4)` depended upon by `Gutenberg`

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.
) during validation.

Pods workspace available at `/var/folders/dq/cdqxvx3s5ps75564rpmb_dc00000gn/T/CocoaPods-Lint-20230703-2698-1tx6bo-Gutenberg/App.xcworkspace` for inspection.

[!] Gutenberg did not pass validation, due to 1 error and 3 warnings.

That either spec fails validation is less of a concern when we consider the upcoming move to XCFrameworks. But I wonder what it'll mean for when we want to use them for local development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant