Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablet layout visual refinements #604

Closed
4 tasks
iamthomasbishop opened this issue Feb 15, 2019 · 1 comment · Fixed by #769
Closed
4 tasks

Tablet layout visual refinements #604

iamthomasbishop opened this issue Feb 15, 2019 · 1 comment · Fixed by #769
Assignees
Labels
[Type] Enhancement Improves a current area of the editor
Milestone

Comments

@iamthomasbishop
Copy link
Contributor

iamthomasbishop commented Feb 15, 2019

This issue covers various refinements related to layout/alignment.

Visualization for reference:

image

Punchlist

  • User should be able to scroll by dragging anywhere on canvas
  • Center column container should have max-width of 580, which provides a nice readable balance/line-length
  • Block boundaries should extend beyond center column by 16 on each side (inner block 580 to edge of container)
  • Quick Toolbar should extend to edges of canvas

Note: Upon further inspection, the container-width might be dependent on readable-margins, so this is probably fine as-is. At least on iOS, when I change the OS-level font-size the container width adjusts (I didn't realize I had my OS-level setting to lower than default). However, the font-size doesn't actually adjust in the editor – I will create another separate issue for this.

@etoledom
Copy link
Contributor

Related: #473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants