1264 - Activate Preformatted block #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment gb-mobile version to 1.14.0 Update bundle files
# Conflicts: # package.json
# Conflicts: # gutenberg
…pens_safari Don't allow interactions with URL in Aztec text blocks. # Conflicts: # gutenberg
…witching to HTML mode
…issing-on-long-posts-in-html-mode
…Content-is-missing-on-long-posts-in-html-mode Fix/1268 content is missing on long posts in html mode
# Conflicts: # gutenberg
# Conflicts: # bundle/android/App.js # bundle/android/App.js.map # bundle/ios/App.js # bundle/ios/App.js.map # gutenberg # react-native-aztec/ios/Cartfile # react-native-aztec/ios/Cartfile.resolved # react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
# Conflicts: # gutenberg
|
@daniloercoli and @etoledom do you mind review this PR? |
# Conflicts: # gutenberg # react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
1 task
|
@daniloercoli and @etoledom do you mind to give it another look, now that all the issues are sorted. |
# Conflicts: # gutenberg
# Conflicts: # gutenberg # react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
2 tasks
# Conflicts: # gutenberg
…ith invalid PRE block content sent to the JS side under some circumstances, even without actually changing the content of the block. Ref: wordpress-mobile/AztecEditor-Android#869 (comment)
….com/wordpress-mobile/gutenberg-mobile into issue/1264_activate_pre_format_block
This was referenced Nov 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1264
GB PR: WordPress/gutenberg#17906
AztecEditor-Android PR: wordpress-mobile/AztecEditor-Android#869
WP-Android PR: wordpress-mobile/WordPress-Android#10764
WP-iOS PR: wordpress-mobile/WordPress-iOS#12934
This PR add the preformated block to the list of available blocks.
To make this work some changes were needed in Aztec and on the refreshFont code to be able to handle scenarios were the active font is not the default font, because pre elements need to use a monospace font.
At the moment this PR also needs an Android Dev to make sure that the pre element is formatted correctly on Android.
To test:
Update release notes:
RELEASE-NOTES.txt.