-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gbm CLI checklist includes "Before the Release" steps #136
Comments
The "Before the Release (Tuesday)" section should always appear for scheduled releases (X.XX.0). One guiding idea in updating the checklist is to remove unnecessary steps. In this case there should be no need to visit PRs assigned to a milestone if that milestone doesn't exist. It does look like we sometimes create milestones for patch releases. Wondering if we should formalize that as being or not being a requirement? I'm fine either way but if we go with the former than yes, the checklist generator should always include this section. On the other hand I'm not sure the intent of the how this step is worded make sense for a patch. I've found this step as a way to help the wrangler point out pending work that they otherwise might not know about. Also the action of pinging someone reminds them that we are nearing a release. Perhaps for a patch release, this step should:
I would think we wouldn't want to move forward with a patch release if there is outstanding work targeting the patch milestone. |
IIRC my intention with this issue was reporting that the "Before the Release" section was absent after I generated as scheduled release checklist using the I agree unscheduled releases are inconsistent as to whether a GitHub milestone is utilized. |
I think this another case of calling the script with out the |
Fixed in #146 |
Generally, we have a task resembling something the following, but it is not currently present in the
gbm
CLI.The text was updated successfully, but these errors were encountered: