Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accents to the verbs #1

Open
popcourn opened this issue Mar 9, 2020 · 6 comments
Open

Add Accents to the verbs #1

popcourn opened this issue Mar 9, 2020 · 6 comments

Comments

@popcourn
Copy link

popcourn commented Mar 9, 2020

Right now there are no accents to the spanish words. For the array of french words they exist.

@wooorm
Copy link
Member

wooorm commented Mar 10, 2020

Hey there! This is not completely true, as abajeña for example is included in the first slice of the file.

We could switch back to the old wordlist, but then we’d loose many words (such as abajeña).

@zeke
Copy link
Member

zeke commented Mar 10, 2020

Maybe we could merge the two sets, favoring the variants that include accents?

@wooorm
Copy link
Member

wooorm commented Mar 10, 2020

How would that favoring work? 🤔

@zeke
Copy link
Member

zeke commented Mar 10, 2020

If you encounter jalapeno and jalapeño, favor jalapeño?

@wooorm
Copy link
Member

wooorm commented Mar 11, 2020

That does assume that if there is a version of a word without accents, then it’s not a valid word. I’m not sure that’s always the case (maybe in Spanish it is though, but the French list includes both abjuré and abjure).

@popcourn
Copy link
Author

There is for example si and sí. Or hablo and habló.
I found a list of 12000 infinitives and a lib to return all declinations of a spanish verb with correct accents. So you could add that list of declinations to the old word list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants