Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added datetime to date conversion to is_holiday() like in is_working_day() #118

Merged
merged 3 commits into from Jan 18, 2016

Conversation

JanMalte
Copy link
Contributor

I think both methods should behave the same if a datetime object is given.

@brunobord
Copy link
Member

looks interesting. could you please provide a test (to avoid potential regressions)?

@JanMalte
Copy link
Contributor Author

I have added a simple test case, just like the one for is_working_day()

@brunobord
Copy link
Member

I'm sorry but this has failed the tests (flake8 issues here). Would you mind fixing them, please?

@brunobord
Copy link
Member

mmm never mind... this flake8 issue is already in master.

(I really need to fix this travis.yml report right away)

@brunobord
Copy link
Member

the good: I've fixed my travis build issue
the bad: now this branch is conflicting, I'm very sorry, but it shouldn't be hard to resolve these,
the good (again): once you'll rebase/merge from master in this branch and push to github, this branch will be built in travis (hopefully) and will report its build status here.

At the minute I'll see the "green" notification in your branch, it'll be merged.

Thank you for your patience.

@brunobord
Copy link
Member

and btw, it'd be great if you amended the changelog

@JanMalte
Copy link
Contributor Author

Ok, should be ready to merge

brunobord added a commit that referenced this pull request Jan 18, 2016
added datetime to date conversion to is_holiday() like in is_working_day()
@brunobord brunobord merged commit 96dbb83 into workalendar:master Jan 18, 2016
@JanMalte JanMalte deleted the patch-1 branch January 18, 2016 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants