Add Ireland #152
Merged
Add Ireland #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Merge ireland.py * Adding Ireland * Add Ireland tests * Add Ireland * Add Ireland * Ireland tests * Ireland changelog
brunobord
requested changes
Dec 2, 2016
| @@ -4,7 +4,7 @@ CHANGELOG | |||
| master (unreleased) | |||
| ------------------- | |||
|
|
|||
| - Nothing changed yet. | |||
| - Add Ireland. thx @gregn610 () | |||
There was a problem hiding this comment.
you may want to add the reference to your pull request (#152)
| "Saint Patrick substitute")) | ||
|
|
||
| # Whit Monday | ||
| if year <= 1973: |
There was a problem hiding this comment.
Maybe you'd need to add a test to check that, before 1974, this day was added to the holidays
| )) | ||
|
|
||
| # May Day | ||
| if year >= 1994: |
There was a problem hiding this comment.
same as above, that be great to test that before 1994, this wasn't a holiday
| days.append(self.get_june_holiday(year)) | ||
| days.append(self.get_august_holiday(year)) | ||
|
|
||
| if year >= 1977: |
There was a problem hiding this comment.
idem ; check before and after 1977.
| self.assertIn(date(2015, 12, 28), holidays) # St. Stephen's day shift | ||
|
|
||
|
|
||
| class IrelandTest(GenericCalendarTest): |
There was a problem hiding this comment.
Probably a copy-paste error, you don't need this duplicate instance of IrelandTest ;o)
|
Don't give up! your contribution is close to be accepted, just a few fixes and it's going to be fine. |
Ireland code review fixes
brunobord
approved these changes
Dec 3, 2016
|
Excellent! welcome to workalendar, Ireland! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For information, read and make sure you're okay with the CONTRIBUTING document.
<country>by@pseudo(#)"