Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Austria #153

Merged
merged 4 commits into from Dec 5, 2016
Merged

Add Austria #153

merged 4 commits into from Dec 5, 2016

Conversation

gregn610
Copy link
Contributor

@gregn610 gregn610 commented Dec 3, 2016

Add Austria

Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small doubt on the label for May 1st.

"Austria"

FIXED_HOLIDAYS = WesternCalendar.FIXED_HOLIDAYS + (
(5, 1, "National Holiday"), # Staatsfeiertag
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this one "Labour Day"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno, could be, I'm not any kind of expert on these things :)
I generally go with with Wikipedia on these things.
Austria.info looks kinda official and the literal translation of Staatsfeiertag is National Day.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, we'll keep it that way until someone finds a better wording ; what's important is the date, the label can wait.

@brunobord
Copy link
Member

there's a tiny conflict in the CHANGELOG, because I've merged the #155 PR

@brunobord
Copy link
Member

so you still have to solve the conflicts with CHANGELOG

@brunobord
Copy link
Member

great one! althought it would have been better to have solved the conflict using "rebase" rather than "merge" to keep your branch clean ; if you need some help to do so for your future contributions, I'd be glad to.

@brunobord brunobord merged commit e72bc7a into workalendar:master Dec 5, 2016
@gregn610
Copy link
Contributor Author

gregn610 commented Dec 5, 2016 via email

@gregn610 gregn610 deleted the austria branch December 19, 2016 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants