New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Historic & one-off updates for South Africa #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, a fantastic contribution! only a few cleanups to do, but nothing severe.
@@ -69,6 +70,89 @@ def test_year_2014(self): | |||
self.assertIn(date(2014, 4, 27), holidays) # freedom day | |||
self.assertIn(date(2014, 4, 28), holidays) # freedom day sub | |||
|
|||
# def test_pre_1994(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, you might not necessarily leave these comments here.
@@ -1,6 +1,12 @@ | |||
CHANGELOG | |||
========= | |||
|
|||
1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer:
master (unreleased)
-------------------
but that's fine ; I'll fix it beforehand.
if holiday.weekday() == SUN: | ||
days.append(( | ||
holiday + timedelta(days=1), | ||
"%s substitute" % label | ||
)) | ||
|
||
# Other one-offs. Don't shift these | ||
if year == 1999: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's an impressive list! wow! amazin work!
refs #
For information, read and make sure you're okay with the CONTRIBUTING document.
<country>
by@pseudo
(#)"