Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Malta #179

Merged
merged 3 commits into from Feb 27, 2017
Merged

Add Malta #179

merged 3 commits into from Feb 27, 2017

Conversation

gregn610
Copy link
Contributor

@gregn610 gregn610 commented Jan 14, 2017 •
edited

refs #

For information, read and make sure you're okay with the CONTRIBUTING document.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Calendar country / label added to the README.rst file,
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)"
  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes.

brunobord
brunobord requested changes Jan 14, 2017
View reviewed changes
Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work again, the usual changelog cleanup, but you're getting used to it.

CHANGELOG
@@ -1,6 +1,8 @@
CHANGELOG
=========

- Add Malta. thx @gregn610 (#179)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to add the header as for the others:

master (unreleased)
-------------------

@brunobord brunobord merged commit 04fec4d into workalendar:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord brunobord requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregn610 @brunobord