Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switzerland: add rules for canton of Vaud #182

Merged
merged 2 commits into from Feb 28, 2017
Merged

Switzerland: add rules for canton of Vaud #182

merged 2 commits into from Feb 28, 2017

Conversation

brutasse
Copy link
Contributor

Switzerland public holidays are canton-specific:

https://en.wikipedia.org/wiki/Public_holidays_in_Switzerland

Canton of Vaud doesn't have Labor day or boxing day, but has its own
"Lundi du Jeûne Fédéral" in september.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Calendar country / label added to the README.rst file,
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)"

Switzerland public holidays are canton-specific:

https://en.wikipedia.org/wiki/Public_holidays_in_Switzerland

Canton of Vaud doesn't have Labor day or boxing day, but has its own
"Lundi du Jeûne Fédéral" in september.
@brutasse
Copy link
Contributor Author

I chose to expose Vaud in the global workalendar.europe namespace but I'm happy to leave it under workalendar.europe.switzerland if that's more suitable (26 cantons, not sure how many of them have the same rules 😄)

@brunobord
Copy link
Member

hey @brutasse, nice to see that you're contributing to this project!

As you may see, I've tackled a few PRs that were on hold for too long, and it resulted in a conflict on the CHANGELOG file. I'm sure you are able to rebase from master and repush your branch ; when it's ready, I'll merge it right away. :o)

@brutasse
Copy link
Contributor Author

@brunobord my pleasure! Conflicts resolved :)

@brunobord brunobord merged commit 8df076f into workalendar:master Feb 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants