Fixing Federal Christmas Shift. #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing because of #245 |
|
For some reasons, travis refuses to install the Python 3.3 & Python 3.5 interpreter, which causes those tests to fail. |
brunobord
requested changes
Sep 29, 2017
| @@ -14,6 +14,7 @@ class UnitedStates(WesternCalendar, ChristianMixin): | |||
| (7, 4, 'Independence Day'), | |||
| ) | |||
| # Veterans day label | |||
| include_veterans_day = True | |||
There was a problem hiding this comment.
I can't see the point of this flag.
Veterans day is unanimously observed by all 50 States, there's no case where you'd have a "False" value here.
There was a problem hiding this comment.
It is not observed by Mozilla, so in https://natim.github.io/Diggory/ I had to turn it to false while inheriting from the US calendar.
There was a problem hiding this comment.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #241
Refs #232