Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISO 3166-1 code for Slovenia #291

Closed
wants to merge 2 commits into from

Conversation

john-sandall
Copy link
Contributor

Slovenia calendar currently has ISO 3166-1 code SL, which is actually Sierra Leone. It should be SI. Source: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#SI

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes.

@brunobord
Copy link
Member

no offense, I've just added a test, squashed your commits and mine into one and credited your work.
I'll make a release as soon as I can. Many thanks for your nice contribution!

@brunobord
Copy link
Member

Tagged and published on PyPI. Happy upgrading! https://pypi.org/project/workalendar/3.1.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants