Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Denmark, remove observances #387

Merged
merged 1 commit into from Jul 7, 2019

Conversation

KidkArolis
Copy link
Contributor

Fix #386

According to the following sources:

https://www.timeanddate.com/holidays/denmark/2019
https://publicholidays.dk/2019-dates/

Palm Sunday, Constitution Day, Christmas Eve and New Year's Eve are Observances and not non working days
This seems to be also true for past years (checked 2015, 2010, 2000)

  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

According to the following sources:

https://www.timeanddate.com/holidays/denmark/2019
https://publicholidays.dk/2019-dates/

Palm Sunday, Constitution Day, Christmas Eve and New Year's Eve are Observances and not non working days
This seems to be also true for past years (checked 2015, 2010, 2000)
@brunobord
Copy link
Member

looking very good! I lack some time right now to merge and release, but I'll try to do this during the week-end...

@KidkArolis
Copy link
Contributor Author

Thanks! No rush.

@brunobord brunobord merged commit f02dbbf into workalendar:master Jul 7, 2019
@KidkArolis KidkArolis deleted the fix-denmark branch July 7, 2019 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Denmark adjustments
2 participants