Fix Denmark - re-add Christmas Eve #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KidkArolis
force-pushed
the
fix-denmark-christmas-eve
branch
from
e2279eb
to
4565975
Compare
|
@KidkArolis could you please rebase and solve the (tiny) changelog conflict, please? (if you can't or don't have time, I'll do it) |
|
right. taking this over. I'll make a release right after |
|
Merged in 6878077 |
brunobord
added a commit
that referenced
this pull request
Nov 15, 2019
**New calendars** - Added 27 Brazil calendars -- thanks a lot to @luismalta & @mileo, (#409 & #415) **Enhancements** - Added compatibility with Python 3.8 (#406). - Added an IBGE_REGISTER to reference IBGE (brazilian) calendars with related tests (#415). - Improve ISO registry interface by raising an error when trying to register a non-Calendar class (#412). **Other changes** - Fixes and additions to some Brazil calendars ; again, thanks to @luismalta & @mileo, (#409 & #415) - Fix Denmark, re-add Christmas Eve, which is widely treated as public holiday ; thx to @KidkArolis, (#414). - Increase Malaysia coverage by adding tests for missing Deepavali & Thaipusam. - Increase China coverage by adding tests for special extra-holidays & extra-working days cases.
|
version 7.1.0 was released and published on PyPI including your fix to the Denmark calendar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've previously removed Christmas Eve from Denmark (together with some other, actually inaccurate public holidays), but as have been pointed out to me by our Danish customers - Christmas Eve is actually being treated as public holiday (even if it's legally not recognized).
Extra sources:
In conclusion, while this stuff is always gonna be ambiguos - I think this particular setup for Denmark is a better default that more accurately represents how people deal with the public holidays there.