Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding holidays for Belarus #472

Merged
merged 1 commit into from Mar 13, 2020
Merged

Adding holidays for Belarus #472

merged 1 commit into from Mar 13, 2020

Conversation

alex-does-stuff
Copy link

@alex-does-stuff alex-does-stuff commented Mar 4, 2020 •
edited

refs #

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.rst file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.
  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

brunobord
brunobord reviewed Mar 13, 2020
View reviewed changes
workalendar/europe/belarus.py
'Belarus'
"as of http://president.gov.by/en/holidays_en/"

include_christmas = False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never thought we'd have this case one day ;o)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh in fact it's already the case in Serbia and Ukraine :o)

@brunobord brunobord merged commit 93a5fbd into workalendar:master Mar 13, 2020
@brunobord
Copy link
Member

Thanks a lot for this new calendar. I'm currently making a new release, stay tuned.

@brunobord
Copy link
Member

The version 8.2.0 is now available from PyPI, and includes Belarus Calendar. Happy upgrading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord brunobord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alex-does-stuff @brunobord