Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add monaco holidays #538

Merged
merged 1 commit into from Aug 21, 2020
Merged

add monaco holidays #538

merged 1 commit into from Aug 21, 2020

Conversation

joaopbnogueira
Copy link
Contributor

refs #

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.rst file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.

brunobord
brunobord approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@brunobord brunobord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution! Many many thanks!

@brunobord brunobord merged commit 60196ec into workalendar:master Aug 21, 2020
@joaopbnogueira
Copy link
Contributor Author

Thank you @brunobord for this great library!

@brunobord
Copy link
Member

Monaco calendar is now available on the latest (10.4.0) release:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobord brunobord brunobord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaopbnogueira @brunobord