Add FederalReserveSystem calendar #695
Conversation
ludsoft
force-pushed
the
FederalReserveSystem
branch
from
f847a46
to
107937e
Compare
ludsoft
force-pushed
the
FederalReserveSystem
branch
from
107937e
to
fe12fec
Compare
| # Juneteenth started to be a federal holiday in 2021 | ||
| if year < 2021: | ||
| raise ValueError("Juneteenth became a federal holiday in 2021") | ||
| return (date(year, 6, 19), "Juneteenth National Independence Day") |
There was a problem hiding this comment.
(just for the sake of it, I double checked the official holiday name: https://en.wikipedia.org/wiki/Juneteenth ✔️ )
|
Hi, |
|
I think there's no ISO code either, they're for countries and regions, not institutions, IIRC. |
|
There's a massive incoming PR with long-time due contributions. It'll most probably cause merge conflicts. You have several solutions here: either I'll merge de meta-PR and let you solve the conflict by rebasing from master ; or I'll integrate your contribution into the meta-PR. What do you think? |
|
Hi, sorry for the delay responding. |
|
you're clear to rebase from master, now. Enjoy! |
|
it was a long shot ; I'll take this over and integrate these changes into master and make a new release (maybe tonight). Stay tuned! |
|
merged (see 45c0b8a) |
|
The US Federal Reserve calendar has been included in the latest release of Workalendar, now available on PyPI! |
refs #
workalendar.registry_tools.iso_registerdecorator to register your new calendar using ISO codes (optional).<country>by@pseudo(#)". Note Please do NOT change the version number here. It's the project maintainers' duty.This is adding the calendar for the federal reserve: https://www.federalreserve.gov/aboutthefed/k8.htm
To do so I needed to add Juneteenth and found this issue: #661 and tried to follow the logic proposed there.
As I was not sure how to test only adding Juneteenth without a calendar using it, both are in a single pull request. Let me know if you would like to split it.
Thanks!