Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El salvador #708

Closed
wants to merge 3 commits into from
Closed

El salvador #708

wants to merge 3 commits into from

Conversation

hersoncruz
Copy link
Contributor

@hersoncruz hersoncruz commented Mar 31, 2022

refs #

For information, read and make sure you're okay with the Contributing guidelines.

  • Tests with a significant number of years to be tested for your calendar.
  • Docstrings for the Calendar class and specific methods.
  • Use the workalendar.registry_tools.iso_register decorator to register your new calendar using ISO codes (optional).
  • Calendar country / label added to the README.md file.
  • Changelog amended with a mention like: "Added <country> by @pseudo (#)". Note Please do NOT change the version number here. It's the project maintainers' duty.
  • Tests with a significant number of years to be tested for your calendar.
  • Changelog amended with a mention describing your changes. Note Please do NOT change the version number here. It's the project maintainers' duty.

(11, 2, "All Saints Day"),
)

def get_variable_days(self, year):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, if it's only to use the "super()" method and return its result, you can remove the lines 21-25, then.

@brunobord
Copy link
Member

The latest release of Workalendar (v17.0.0), including the new El Salvador calendar, has been published on PyPI. More informations on:

Happy upgrading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants