Boxing Day is not being shifted when it falls on a Saturday #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay falls on a week day but Boxing day falls on the weekend
|
looks great! thanks for the bugfix! |
brunobord
added a commit
that referenced
this pull request
Oct 6, 2014
Boxing Day is not being shifted when it falls on a Saturday
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the UK and Northern Ireland, holiday days are observed in lieu of Christmas Day and Boxing Day if either of those days falls on a weekend. The current logic for shifting these dates (in
workalendar.europe) is only triggered when Christmas Day falls on a weekend and so does not account for the scenario where Christmas Day falls on a Friday, meaning that Boxing Day is on a Saturday and should be shifted to the following Monday.Please review my changes in
workalendar.europe, where I've added an additional clause to account for this particular scenario. I've also added a unit test intest_europe.UnitedKingdom.Hope this is correct.
P.S. thanks for the great library!