Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Makes sure that constraints are satisfied #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

soluchok
Copy link

@soluchok soluchok commented Dec 11, 2020

Closes #3

Signed-off-by: Andrii Soluk isoluchok@gmail.com

Signed-off-by: Andrii Soluk <isoluchok@gmail.com>
@soluchok
Copy link
Author

@glcohen please, take a look

@decentralgabe
Copy link
Contributor

Thank you, @soluchok I intend to incorporate this into the next release which I can push out later today. Our pipeline requires that the change comes from our system first as the source of truth. I will make sure to credit you as the author in the following file https://github.com/workdaycredentials/ledger-common/blob/master/CREDITS.md

@soluchok
Copy link
Author

soluchok commented Dec 11, 2020

@glcohen this change should be backward compatible. The problem comes out when we have more than one Fields (descriptor.Constraints.Fields). Currently, when at least one field is valid, validation says that the whole descriptor is valid. But actually, it is not. Because descriptor is one entity. The descriptor should be valid when all descriptor.Constraints.Fields are valid. Correct me if I am wrong.

@decentralgabe
Copy link
Contributor

You are correct 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraints validation doesn’t work properly
2 participants