Skip to content
This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Setting unknown property: workingconcept\lever\models\LeverJob::country #2

Closed
justinholtweb opened this issue Sep 12, 2022 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@justinholtweb
Copy link

Plugin started returning an error when calling the LeverJob class. Setting unknown property: workingconcept\lever\models\LeverJob::country. I assume possibly the API at Lever has changed?

Craft: Craft Pro 3.6.18
Lever: 1.0.3

@mattstein
Copy link
Contributor

Looks like they added country to the documentation on August 11th. I don’t have a Lever account to test with anymore and last I checked they didn’t offer developer-only accounts, but I can certainly YOLO-update the model here.

@justinholtweb
Copy link
Author

@mattstein that would be awesome. I might be able to get you access to my client's Lever account if that would help?

@mattstein
Copy link
Contributor

@justinholtweb I appreciate that, and I’d rather ask you to confirm success if you don’t mind. Assuming it’ll be painless and I can get to this soonish.

@mattstein mattstein self-assigned this Sep 12, 2022
@mattstein mattstein added the bug Something isn't working label Sep 12, 2022
@justinholtweb
Copy link
Author

@mattstein absolutely can, just let me know when you get a patch up and I can test right away. Thanks!

@mattstein
Copy link
Contributor

Hey @justinholtweb, just added two new job properties in a 1.0.4 branch. Would you mind giving that a try when you have a moment?

Their API docs say country data should start flowing in this month—explaining why you’re seeing it now—and workplaceType should start appearing in October. Both are accounted for here.

@justinholtweb
Copy link
Author

@mattstein this worked!

@mattstein
Copy link
Contributor

Lovely, I’ll tag a new release. Thanks for confirming @justinholtweb!

@mattstein
Copy link
Contributor

This is in 1.0.4, which I just published. Thanks again!

@justinholtweb
Copy link
Author

Thank you @mattstein

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants