Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve video size on workout #32

Closed
Vincenius opened this issue Jul 5, 2023 · 4 comments · Fixed by #45
Closed

Improve video size on workout #32

Vincenius opened this issue Jul 5, 2023 · 4 comments · Fixed by #45

Comments

@Vincenius
Copy link
Contributor

Make the videos a bit bigger depending on the screen size and let the user maximize (resize?) it.

@ngthuongdoan
Copy link
Collaborator

https://ant.design/components/image#components-image-demo-controlled-preview
@Vincenius You means something like this but for video right

@Vincenius
Copy link
Contributor Author

Yeah, I was thinking of increasing the size of the videos in the modal on the preview (see screenshot). Maybe fullscreen as you proposed would make sense 🤔

Also I'd adjust the size on the workout screen when you do the exercises.

Screenshot 2023-07-11 at 09 33 11

@ngthuongdoan
Copy link
Collaborator

image @Vincenius I changed to modal is it ok? I think with this size we don't need the fullscreen feature.

@Vincenius
Copy link
Contributor Author

yeah, looks good 👍 I'll review it later today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants