Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand property to BottomSheet library #5

Closed
devnunu opened this issue Sep 14, 2022 · 4 comments
Closed

Add expand property to BottomSheet library #5

devnunu opened this issue Sep 14, 2022 · 4 comments

Comments

@devnunu
Copy link

devnunu commented Sep 14, 2022

hello. I'm using your library very well.
While using the library, I found that there is no expand function.
So, when I want a bottomSheet that covers the entire screen, I have to open the bottomSheet twice by swiping.

Can you fix this by adding a property for expand? If this property is added, the usability of the library will be better.
(By the way, your library is really cool)

@workspace
Copy link
Owner

Hi @devnunu. Thank you for your opinion and sorry for late reply. I'll check it soon.

@workspace
Copy link
Owner

Hi @devnunu, sorry for late reply.

I'll added some properties to set bottomsheet's behavior.
You can set BottomSheetBehavior.state and BottomSheetDialog will be expanded at first like this. Is it enough?

Screen_Recording_20221026_212241_bottomsheetdialog-compose.mp4

@workspace
Copy link
Owner

@devnunu
Closed with #8.

Try this

BottomSheetProperties(
    ...,
    behaviorProperties = BottomSheetBehavior(
        ...,
        state = State.Expanded
    ) 
)

@devnunu
Copy link
Author

devnunu commented Nov 3, 2022

I'm also sorry for the late reply. Perfectly the feature I wanted. Thanks for taking care of it. you guys are the best team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants