Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest angular and slatejs versions #229

Closed
dweggemans opened this issue May 30, 2023 · 3 comments · Fixed by #246
Closed

Upgrade to latest angular and slatejs versions #229

dweggemans opened this issue May 30, 2023 · 3 comments · Fixed by #246
Assignees
Labels
enhancement New feature or request

Comments

@dweggemans
Copy link

Could you please upgrade this library to support the latest angular and slate versions? I've tried to provide a pull request, but ran into some issues that I don't know how to resolve.

Thanks!

@pubuzhixing8 pubuzhixing8 added the enhancement New feature or request label Jun 2, 2023
@pubuzhixing8 pubuzhixing8 self-assigned this Jun 2, 2023
@pubuzhixing8
Copy link
Collaborator

I intend to upgrade latest version of slate recently, but it could be a long time because there are too much version to study and synchronize.
We need to make sure that these commits are stable.
Upgrading Angular to 16 is more easy, we'll complete it soon.

@dweggemans
Copy link
Author

Any news or timeframe on these upgrades?

@BenRacicot
Copy link

BenRacicot commented Sep 5, 2023

Hi, yes I noticed that my npm is demanding slate-history@"^0.66.0"

npm ERR! Could not resolve dependency:
npm ERR! peer slate-history@"^0.66.0" from slate-angular@16.0.0

Here is from the readme (compared w latest)

"dependencies": {
    "direction": "^1.0.3",         →   ^2.0.1
    "is-hotkey": "^0.1.6",        →   ^0.2.0
    "slate": "0.67.1",                 →   0.94.1
    "slate-history": "0.66.0",  →   0.93.0
    "slate-angular": "1.6.5"    →   16.0.0
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants