Skip to content
This repository has been archived by the owner on Apr 7, 2024. It is now read-only.

JS error on account creation #44

Closed
Arundel2017 opened this issue Oct 17, 2020 · 4 comments · Fixed by #57
Closed

JS error on account creation #44

Arundel2017 opened this issue Oct 17, 2020 · 4 comments · Fixed by #57
Assignees
Milestone

Comments

@Arundel2017
Copy link

On creating an account I encountered the error message attached.

Steps taken:

Followed the login -> register for an account steps from the home page
Entered name, email, and password, hit 'submit' or equivalent button.
Was taken to the route: http://www.ucompass.tech/profile where I saw this error message.

registrationError

@arjunmuralidharan
Copy link
Collaborator

It looks like we are not handling the case where a student has written no reviews yet, and hence reviews is undefined. I think I can fix this.

@Arundel2017
Copy link
Author

Yep, I'm met with the same error when I try to add my first review, it takes me to the same 'profile' route where I get the same JS error.

@arjunmuralidharan arjunmuralidharan self-assigned this Oct 17, 2020
@ankush
Copy link
Collaborator

ankush commented Oct 17, 2020

This was apparently due to some configuration error (while deploying to production server). I cannot reproduce this locally and now on prod setup too.

I am leaving this issue and #45 open for further exploration and making things more robust.

@ankush ankush added this to the release milestone Oct 18, 2020
@arjunmuralidharan arjunmuralidharan linked a pull request Oct 19, 2020 that will close this issue
@arjunmuralidharan
Copy link
Collaborator

I've added some basic checking to catch this error in the future.

@arjunmuralidharan arjunmuralidharan linked a pull request Oct 19, 2020 that will close this issue
@arjunmuralidharan arjunmuralidharan added this to To do in REPL Reviews v1 via automation Oct 19, 2020
REPL Reviews v1 automation moved this from To do to Done Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
3 participants