default of argument coverage() should be "all"

[randrescastaneda]

Hi Tony,

By default, the Stata package loads coverages levels when option coverage is left empty povcalnet, country("all"). However, the R package filters everything that is not national by default. In this case, countries like Argentina, which does not have national coverage, are excluded from the output when povcalnet(country = "all") is executed.

I could update that if you want, but I thought it would be better if you do it.

Thanks.
Best,
Andres

[tonyfujs]

Hey Andres,
Yes, this was by design. I felt it was much cleaner and easy to reason about when coverage levels are not mixed in the response. This is how the PovcalNet API works however so I guess we should stick to it as much as possible... An additional "all" parameter should work fine. I'll make the modifications and let you know when it's ready.

[randrescastaneda]

Awesome! Thanks. Best, ---------------------- R.Andrés Castañeda Development Economics, Data Group | PovcalNet

[tonyfujs]

Hey @randrescastaneda ,
Let me know if you have a few minutes to talk about this today. I'm not sure this is good idea afterall: It is has some side effects that are not pretty...

[randrescastaneda]

Hey @tonyfujs ,

Sure. Let's talk today. Are you available at 9am DC time?

[tonyfujs]

Yep! Sending an invite now.