Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: core and standalone packages; adds prepublish script #176

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Conversation

m1guelpf
Copy link
Member

No description provided.

@m1guelpf m1guelpf requested a review from pdtfh November 22, 2023 20:06
@m1guelpf m1guelpf self-assigned this Nov 22, 2023
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
idkit-js-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 8:06pm

@@ -7,4 +7,5 @@ export default defineConfig({
outDir: 'build',
external: ['zustand', 'viem'],
entry: ['src/index.ts', 'src/lib/hashing.ts'],
define: { 'process.env.NODE_ENV': '"production"' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's document why this is needed

entry: ['src/index.ts', 'src/internal.ts'],
define: {
'process.env.NODE_ENV': '"production"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, let's document why this is needed

@pdtfh pdtfh merged commit 9dd7a96 into main Nov 24, 2023
5 of 6 checks passed
@pdtfh pdtfh deleted the quick-fixes branch November 24, 2023 22:42
This was referenced Jan 2, 2024
@github-actions github-actions bot mentioned this pull request Jan 26, 2024
@github-actions github-actions bot mentioned this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants