Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF52832 support #99

Closed
baramuse opened this issue Jun 5, 2019 · 3 comments
Closed

nRF52832 support #99

baramuse opened this issue Jun 5, 2019 · 3 comments

Comments

@baramuse
Copy link

baramuse commented Jun 5, 2019

Hi,

I'm trying to get the library work with my Adafruit Bluefruit Feather (nRF52832) but can't compile the sketches, I tried the PulseSensor_BPM_Alternative :

In file included from PulseSensor_Playground/src/PulseSensorPlayground.h:439:0,
                 from PulseSensor_Playground/src/PulseSensorPlayground.cpp:16:
PulseSensor_Playground/src/PulseSensorPlayground.cpp: In member function 'boolean PulseSensorPlayground::sawNewSample()':
PulseSensor_Playground/src/utility/Interrupts.h:71:45: error: 'cli' was not declared in this scope
 #define DISABLE_PULSE_SENSOR_INTERRUPTS cli()
                                             ^
PulseSensor_Playground/src/PulseSensorPlayground.cpp:105:5: note: in expansion of macro 'DISABLE_PULSE_SENSOR_INTERRUPTS'
     DISABLE_PULSE_SENSOR_INTERRUPTS;
     ^
PulseSensor_Playground/src/utility/Interrupts.h:72:44: error: 'sei' was not declared in this scope
 #define ENABLE_PULSE_SENSOR_INTERRUPTS sei()
                                            ^
PulseSensor_Playground/src/PulseSensorPlayground.cpp:108:5: note: in expansion of macro 'ENABLE_PULSE_SENSOR_INTERRUPTS'
     ENABLE_PULSE_SENSOR_INTERRUPTS;
     ^
exit status 1
Error compiling for board Adafruit Bluefruit nRF52832 Feather.

Any idea how can I get out of this ?

Cheers

@biomurph
Copy link
Contributor

biomurph commented Jun 5, 2019

@baramuse
We are aware of this issue, and we are working on a solution for it.
Likely it will first be a fix for the BPM_Alternative sketch, with support for interrupts coming after that.

@baramuse
Copy link
Author

baramuse commented Jun 5, 2019

Thanks for your update, I'll keep on eye on this issue then, and will continue my work with other compatible boards (avr ones ?)

@biomurph
Copy link
Contributor

@baramuse
I have updated the PulseSensor Playground library with support for the Adafruit Bluetooth Feather (nRF52832). I did a cursory check on 'generic' nRF52832 boards and they don't seem to throw the same error.
Please download the library from this repository. I have not created a new release yet. I will try to get some more changes made before I update the release that can be accessed through the Arduino Libraries Manager tool. If you have any issues, please re-open this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants