Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links on Kolibri index #45

Open
richsegal opened this issue Feb 12, 2019 · 0 comments
Open

Broken links on Kolibri index #45

richsegal opened this issue Feb 12, 2019 · 0 comments

Comments

@richsegal
Copy link

I figured this was the best place to report module bugs as they do not have a repository of their own. Please let me know if there is a better place to report this bug.

The Kolibri index module provides links at the bottom of its tile to jump to the Kolibri create account page and Kolibri login page. Both links do not work due to the use of an incorrect syntax for embedding PHP variables in strict literals. The line of code:

echo "
    <p style='margin-left: 130px;'>
        You can <a href='<?php echo $host ?>/user/#/create_account'>create an account to track progress</a>.
        Later, you can <a href='<?php echo $host ?>'>login again and continue where you left off</a>.
    </p>
";

should read:

echo "
    <p style='margin-left: 130px;'>
        You can <a href='$host/user/#/create_account'>create an account to track progress</a>.
        Later, you can <a href='$host'>login again and continue where you left off</a>.
    </p>
";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant