Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with new json configuration format. #17

Closed
pguridi opened this issue Jan 6, 2014 · 3 comments
Closed

issues with new json configuration format. #17

pguridi opened this issue Jan 6, 2014 · 3 comments

Comments

@pguridi
Copy link
Contributor

pguridi commented Jan 6, 2014

couldnt make it work with the latest changes.
Would be good to have an example configuration file, with all the possible options.

How do I setup the database server credentials now?.

@worldveil
Copy link
Owner

The latest changes make it so that any dictionary can be handed in. So whether you read a json file and convert to dict or unpickle a dictionary, etc it's up to you.

I do agree we should probably document all the configuration options. database, with user, host,pwd and db are obviously needed. database_type is supported. What option options might we want to provide?

@pguridi
Copy link
Contributor Author

pguridi commented Jan 6, 2014

I understand the advantages of the new format.., I think is simpler. But with the feature merge, a working example should be added too. Besides the format.., is the code really reading the config file?.

  • - What happened with the feature I pushed, for limiting the fingerprinting seconds? (It was configurable using the config file before)

are we sure this is not a regression, and dejavu is not currently broken?.

@Wessie
Copy link
Contributor

Wessie commented Jan 6, 2014

Due to my usage of dejavu as a library more than a program I seem to indeed have regressed your limiting change.

Or better said, it isn't exposed through the command line interface. It's implemented in decoder.read and just has to be re-exposed as it was before. Exposing it without affecting library usage would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants