Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex string breaks formatting for rest of a go document. #6

Closed
odoland opened this issue Feb 6, 2024 · 5 comments
Closed

Regex string breaks formatting for rest of a go document. #6

odoland opened this issue Feb 6, 2024 · 5 comments

Comments

@odoland
Copy link

odoland commented Feb 6, 2024

Steps to replicate:

Copy paste this on top of a go file.
var demo = regexp.MustCompile(^(?i)(CS)(\d{3,4}))

image image

On go 1.21.0
All extensions disabled.
VS code about.

Version: 1.86.0 (Universal)
Commit: 05047486b6df5eb8d44b2ecd70ea3bdf775fd937
Date: 2024-01-31T10:29:15.765Z
Electron: 27.2.3
ElectronBuildId: 26495564
Chromium: 118.0.5993.159
Node.js: 18.17.1
V8: 11.8.172.18-electron.0
OS: Darwin x64 22.6.0
@worlpaker
Copy link
Owner

Thanks for the details! VS Code using the old version of Go Syntax. I think this issue was fixed in v0.5.7.
Can you please install the extension and try it? (Install from here: https://marketplace.visualstudio.com/items?itemName=furkanozalp.go-syntax)

Dark+ Theme v0.5.7
test

@alexr00
Copy link

alexr00 commented Feb 7, 2024

It looks like VS Code insiders also already has this fix!

@alexr00
Copy link

alexr00 commented Feb 7, 2024

I've also just pulled updates to the grammar into VS Code again so we have the latest in insiders.

@worlpaker
Copy link
Owner

FYI: There is a new update (v0.5.8).

@odoland
Copy link
Author

odoland commented Feb 7, 2024

Thanks for the details! VS Code using the old version of Go Syntax. I think this issue was fixed in v0.5.7. Can you please install the extension and try it? (Install from here: https://marketplace.visualstudio.com/items?itemName=furkanozalp.go-syntax)

Dark+ Theme v0.5.7 test

Thanks, grabbing this extension and installing it worked!

I'll play around in the latest insiders edition for VSCode to see if we can catch any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants