New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana: fix lamport beneficiaries #109
Conversation
426e2e5
to
769790c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the account close changes look good.
I'm curious the values are being extracted from ExecuteOrder now instead of passing the struct along directly as before?
Do you mean here? Lines 21 to 27 in 769790c
I did this because I lazily passed a mutable reference to the whole ExecuteOrder composite before. I think passing each account from this context reflecting whether each account should be a static ref or mut ref feels better. What do you think? As I look at this more, it's an interesting trade off of whether to pass specific references of each account from the composite. Or to pass the composite to leave it less error-prone to reference each account in the composite. I guess inside the shared method I could specify static references to specific accounts. Is that preferred? |
769790c
to
d0d7faa
Compare
Made the change here: 731df93. This does feel better. What do you think? |
config, | ||
best_offer_token, | ||
} = active_auction; | ||
let auction = &mut execute_order.active_auction.auction; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at all those references.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐔
Going to merge this. @johnsaigle if you have a strong opinion about how the refs should be passed, I'll put up another PR after we discuss it. |
PreparedOrderResponse
PreparedOrder
Closes #104.