Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo displaying of ads #83

Closed
Wotuu opened this issue Nov 9, 2018 · 1 comment
Closed

Redo displaying of ads #83

Wotuu opened this issue Nov 9, 2018 · 1 comment
Assignees
@Wotuu
Labels
bug Something isn't working

Comments

@Wotuu
Copy link
Contributor

Wotuu commented Nov 9, 2018

I used the automatic placement of Google Ads on the website to save me having to do it myself. The results looked alright in the beginning, but in the end it placed them on strange positions all across the page. Not to mention the new UI layout completely broke with it enabled at all.

Time to put in some more effort for a tailored experience that won't annoy as much people as they would with the automatic placement.
@Wotuu Wotuu added the bug Something isn't working label Nov 9, 2018
@Wotuu Wotuu self-assigned this Nov 9, 2018
Wotuu added a commit that referenced this issue Nov 9, 2018
@Wotuu
#83 Added manual ads to the site. Still WIP.
4e5bfd6
Wotuu added a commit that referenced this issue Nov 18, 2018
@Wotuu
#83 Redid ads, almost done. Needs a few touch ups still.
ffb6756
@Wotuu
Copy link
Contributor Author

Wotuu commented Nov 19, 2018

Ads are enabled again. There may be an issue with the map ad still, but I'll make a separate issue for that.

@Wotuu Wotuu closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wotuu Wotuu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Wotuu