Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth <1m #15

Closed
wouterpeere opened this issue Aug 17, 2022 · 2 comments
Closed

Depth <1m #15

wouterpeere opened this issue Aug 17, 2022 · 2 comments
Milestone
v2.0.5

Comments

@wouterpeere
Copy link
Owner

Sometimes, due to the iterative nature of the depth calculation, one iteration step requires a depth <1m. The program then crashes, sinces 1m is the minimal depth.

We will add a check for this to say that the depth should at least be 1m. If it keeps converging towards a smaller value, we will return an error.
@wouterpeere
Copy link
Owner Author

Has been addressed in the improvement branch!

wouterpeere pushed a commit that referenced this issue Aug 17, 2022
Fixed bug (issue #15)
800670c
@wouterpeere wouterpeere reopened this Aug 18, 2022
@wouterpeere wouterpeere added this to the v2.0.5 milestone Aug 18, 2022
@wouterpeere
Copy link
Owner Author

Will be published in v2.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.5
Development

No branches or pull requests
1 participant
@wouterpeere