Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when temperature plotting with borefield with different borehole lengths #233

Closed
wouterpeere opened this issue Feb 23, 2024 · 2 comments · Fixed by #234
Closed

Bug when temperature plotting with borefield with different borehole lengths #233

wouterpeere opened this issue Feb 23, 2024 · 2 comments · Fixed by #234
Assignees
Labels
bug Something isn't working
Milestone

Comments

@wouterpeere
Copy link
Owner

Currently, GHEtool assumes in a couple of methods that the depth of the borefield is equal to the depth of the first borehole. This can be seen in:
self.H = self.borefield[0]

This is not a problem in sizing, but it is in temperature plotting, for there, the power is divided based on the number of boreholes and the borehole length.

The solution can be to redefine the self.H as being the average of all the borehole lengths when loading a borefield.

@wouterpeere wouterpeere added the bug Something isn't working label Feb 23, 2024
@wouterpeere wouterpeere added this to the v2.3.0 milestone Feb 23, 2024
@wouterpeere
Copy link
Owner Author

Bug is fixed, but one test is now way slower than before (optimise_load_profile_energy). This has to be investigated further.

@wouterpeere wouterpeere self-assigned this Feb 23, 2024
@wouterpeere
Copy link
Owner Author

The timing issue seems to be non-existent.
There is however a deeper challenge w.r.t. the g-function class. When a borefield with two boreholes of 100 and 150m are calculated, the average depth is 125m and it is hence stored in the gfunction class. When later the borefield is changed to have two times 125m, the gfunctions are the same, which is wrong.
This will be solved by setting the 'store_previous_values' to false whenever the boreholes are not the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
1 participant