-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NavigationToolbar to Figure #55
Comments
Hi @wouterpeere , the following points have been fixed:
Can you please have a look at it and check that everthing works? With best regards |
Hi @tblanke Perfect, thanks! Best, |
@tblanke I noticed you created 'fig_temperature' and 'fig_load_duration' variable in main_class.py. In the latter case, I would prefer the figure to be saved in the DataStorage object itself instead of in the borefield object. This simplifies the code in the main class. |
Hi @wouterpeere , That is a good idea. I have made to adaptions for this and pushed in the branch. With best regards |
Run display_results each time the result page is shown (solves problem refered to in issue #55) Restate add_link_2_show
Hi @tblanke This already looks nicer! I noticed some more strange behaviour:
|
I also made a change to the way the figures are saved in DS. Now, the figures were hardcoded, meaning that every time a new ResultFigure was placed in the gui_structure, this also had to be changed in the DS. |
Some more strange behaviour: When you load a file that was calculated, the figure displays from the first time (which is perfect), however the labels are not displayed. Is it possible that they aren't saved in the DS? |
I have fixed the label issue. |
I can not reproduce the "figure on the result page gets bigger" issue. Can you try to update the packages to the newest version and check if that solves the issue? |
Matplotlib and PySide6 are both the latest versions. |
Does it work now? |
@tblanke, no it did not. It caused even some problems while loading. Can you confirm that everything is still working by you? |
Correct. |
Perfect! I will finish my review, check if all the documentation still is correct and I will do the PR. W.r.t. testing, looking at the coverage results, about 500 lines in combine_gui_window are not tested currently. Do you think it would be possible to increase the test coverage for the gui? |
Hi @wouterpeere , Great, from my side you can start with the PR. With best regards |
@tblanke , is there a particular reason why you reset the location of the BACKUP.GHEtool to the default save location? I switched it to another directory because, if one overwrites this backup.ghetool document, it can cause issues. |
Hi, I have changed the location, because otherwise the default location is the current working directory. This is an issue for the installed version, because then this location may be in a folder where just admins are allowed to read and write files. I think this is the problem, why the program crashed in the past. |
We have to create a hidden folder and no hidden file, because the hidden file is causing Permission errors. I have created a new commit for this. |
Or, instead of creating a hidden folder, we can change the extension for the backup to *.ghetoolbackup, so it won't show up in the dialog box when saving? |
That is a better idea. I have made the changes. |
I checked the gui and all looks fine. I've added some more Dutch translations and fixed a small bug w.r.t. the ResultTexts. I will open the PR. @tblanke will you be able to create some more unit tests for the gui in this issue? |
Hi @wouterpeere , I will create a new branch for the gui testing. With best regards |
Hi @wouterpeere,
I have added a Navigation Toolbar to the figures.
Maybe then the save Figure button is obsolet then.
With best regards
@tblanke
The text was updated successfully, but these errors were encountered: