Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom repositories in transactions #220

Open
tzvc opened this issue Dec 31, 2020 · 3 comments
Open

Use custom repositories in transactions #220

tzvc opened this issue Dec 31, 2020 · 3 comments
Labels
feature-request Feature Request help wanted Extra attention is needed

Comments

@tzvc
Copy link

tzvc commented Dec 31, 2020

Hi there,

I was wondering, is there a way to use custom repositories when running a transaction in multiple repositories? The transaction object expose a getRepository but no getCustomRepository method :/

Cheers!

@wovalle
Copy link
Owner

wovalle commented Jan 11, 2021

Hey!

You're right. transaction object only esposes a getRepository which is a TransactionRepository itself rather than a CollectionRepository which is what's returned by getRepository and getCustomRepository in fireorm.

As of now, I cannot reuse the same repositories because the ones with transaction need some special treatment.

What's the use case for this?

@fkpage
Copy link

fkpage commented Mar 7, 2021

Hi,

Is there any chance that will be supported?

@wovalle
Copy link
Owner

wovalle commented Mar 7, 2021

This is something I'll totally will look into but don't have enough time to do it soon.

Even though I think the fix is not that hard, contributions are welcome!

@wovalle wovalle added feature-request Feature Request help wanted Extra attention is needed labels Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Feature Request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants