Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests #31

Closed
wovalle opened this issue May 23, 2019 · 3 comments 路 Fixed by #72
Closed

Integration tests #31

wovalle opened this issue May 23, 2019 · 3 comments 路 Fixed by #72
Labels
help wanted Extra attention is needed released
Milestone
v1

Comments

@wovalle
Copy link
Owner

wovalle commented May 23, 2019 •
edited
Loading

This project is being used in several production apps. It's time to actually use a real Firestore db to ensure we don't break anything on each release 馃槃

Acceptance Criteria:

  • Refactor the existing fixtures to plain json files so they can be used for unit/integration tests
  • Predictable setup/teardown process
  • Generate collection names with random ids to prevent collisions
@wovalle wovalle mentioned this issue May 23, 2019
Open
24 tasks
@jonesnc
Copy link
Contributor

jonesnc commented May 30, 2019

This looks like an interesting method for preventing collisions:

https://medium.com/promise-eng/blazing-fast-tests-with-firebase-15x-quicker-155467318d65

@wovalle
Copy link
Owner Author

wovalle commented May 30, 2019

That indeed looks good! I'm not a fan of editing (shimming, as they call it) the default behavior of the firestore object but I will definitely take hints from their implementation. Thanks for sharing!

@wovalle wovalle added this to the v1 milestone Jun 27, 2019
@wovalle wovalle added the help wanted Extra attention is needed label Jul 2, 2019
This was referenced Jul 9, 2019
Closed
Closed
Merged
@whateverbot
Copy link
Collaborator

馃帀 This issue has been resolved in version 0.6.5 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed released
Projects
None yet
Milestone
v1
Development

Successfully merging a pull request may close this issue.

test: integration tests wovalle/fireorm
3 participants
@jonesnc @wovalle @whateverbot