figure shortcode no longer supports SVG images

[thomwiggers]

Describe the bug

A clear and concise description of what the bug is.

Using

{{< figure src="some.svg" >}}

now results in

Building sites … Total in 352 ms
Error: Error building site: "/home/thom/git/thomwiggers.nl/content/post/kems_in_tls_1.3/index.md:52:1": failed to render shortcode "figure": failed to process shortcode: "/home/thom/git/thomwiggers.nl/themes/academic/layouts/shortcodes/figure.html:6:22": execute of template failed: template: shortcodes/figure.html:6:22: executing "shortcodes/figure.html" at <$asset.Fit>: error calling Fit: *resources.genericResource is not an image

To Reproduce

Steps to reproduce the behavior:

Put an svg in your page

Expected behavior

SVG gets linked correctly

Technical details:

• Academic Version: 8d25dbc
• Hugo Version: v0.65.3-211BA42A/extended

[thomwiggers]

Git bisect suggests 55228b7 is to blame.

[gcushen]

Note that Hugo does not currently support SVG as an image type but as a generic resource within the Hugo framework.

Academic's Figure code was not intended to work with SVG given Hugo does not yet support SVG as an image type, although in some versions of Academic it may have worked. Hence, this would be more of a question and feature request for adding SVG support to figures. Feel free to submit a PR.

An alternative approach for SVG might be to utilise the standard Markdown image syntax, with the caveat that it won't have the flexibility of figures.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. The resources of the Academic team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically close soon if no further activity occurs. Thank you for your contributions.

[beckerjohannes]

@gcushen could you reopen the issue and I'll provide a PR for this?

The current figure shortcode implementation tries to resize "image" resources and for others it just creates an <img> link.

The problem is, Hugo returns SVG for .Page.Resources.ByType "image", but does not support Fit. However, I fixed it for my site by additionally checking if .MediaType.SubType is equal to svg and skipping .Fit for those.