Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Emoji icon pack and Custom SVG icon pack support #1698

Closed
2 tasks
gcushen opened this issue May 14, 2020 · 7 comments
Closed
2 tasks

Extend Emoji icon pack and Custom SVG icon pack support #1698

gcushen opened this issue May 14, 2020 · 7 comments

Comments

@gcushen
Copy link
Collaborator

gcushen commented May 14, 2020

Feature Request

Extend Emoji icon pack and Custom SVG icon pack support from Featurette widget to all other places where icon packs can be used, such as page button links.

See #1149
See #1692

Todo

  • refactor the icon logic from Featurette widget into a function
  • update all icon instances to call function
@rodrigoalcarazdelaosa
Copy link
Contributor

Will this make it to v4.9? Really looking forward to it! Thanks!

@rodrigoalcarazdelaosa
Copy link
Contributor

rodrigoalcarazdelaosa commented Jun 2, 2020

I will leave here this comment (feature request) so as not to open another issue.

Feature Request

Is your feature request related to a problem? Please describe.
Current built-in support for asides (alerts) is only available for notes and warnings, whose styles can be customized with CSS.

Describe the solution you'd like
It'd be great if we could use custom icons (all types) in asides (alerts) without having to customize our CSS.

Describe alternatives you've considered
Right now one can create another type of aside (alert) by writing just some lines in assets/scss/custom.scss. Let's say we want an example alert, with a lightbulb icon from Font Awesome and some green colors:

div.alert-example > div:first-child::before {
  font-family: 'Font Awesome 5 Free';
  font-weight: 900;
  color: #4c5f26;
  content: '\f0eb';
}

.alert-example {
  color: #111111;
  background-color: #ccddaa;
  border-color: #4c5f26;
}

Then we would write:

{{% alert example %}}
This is an example text.
{{% /alert %}}

It'd be better if we could specify the icon we want, actually the basic styling such as colors for example, without having to write those CSS lines for each new aside (alert) we want to have.

Additional context
The code above gives this:
image

@rodrigoalcarazdelaosa
Copy link
Contributor

rodrigoalcarazdelaosa commented Jun 8, 2020

Related to this, Font Awesome 6, to be released in the second half of 2020, will allow us to upload our own icons, and use them just as if they were Font Awesome icons, so I can imagine a future version of Academic where this may not be needed at all.

That will probably be a PRO feature though.

@rodrigoalcarazdelaosa
Copy link
Contributor

If/when this is implemented we could change the sharing icons from Font Awesome to the actual brand logos, from this:
image
to this (envelope is from Twemoji):
image

@rodrigoalcarazdelaosa
Copy link
Contributor

How about using this technique to use custom SVGs as if they were emojis? In order to being able to still use normal emojis, we should choose another escape character (not the semicolon :). Will try it 😉

@rodrigoalcarazdelaosa
Copy link
Contributor

@gcushen, relevant project that can help with this.

@gcushen
Copy link
Collaborator Author

gcushen commented Dec 21, 2021

Closing as the issue has been open for over a year with no contributions and little-no interest from the community.

PRs are welcome if anyone comes across this and wishes to contribute an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants