Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arpen total is confusing for Warrior in Battle stance #3588

Open
jdelvare opened this issue Aug 31, 2023 · 3 comments
Open

Arpen total is confusing for Warrior in Battle stance #3588

jdelvare opened this issue Aug 31, 2023 · 3 comments
Labels

Comments

@jdelvare
Copy link

Describe the bug
The total displayed for Armor Penetration does not match the sum of individual fields.

To Reproduce
Steps to reproduce the behavior:

  1. Hover the Armor Penetration line of the Stats table.
  2. Compute the sum of individual fields and compare with the total.

Expected behavior
I would expect the total to always match the sum of individual stat fields.

Sim Links and Screenshots
arpen

https://wowsims.github.io/wotlk/warrior/#eJztk0FoE0EUhve9xHSzBDLNQcZISlw8BKEwO2uQXtxJT3oQmhyEiiBFKoIeShCqPaXRYvGiJ4kBkXoQQcFTxAqCpEIRmxBY8eBJKsZISw3alEhFOrvTo4Kl8eYPO7N8s+//H8sbI6IjwwnoAjYQh/Uk3gJ4CBDT4p09RQiNXBy7Mp7XAyQcr4IRJYstpF8SZujpAj6ZRyNIasWAESEbP5B+SJiBimRR0viM9I1uhuQXdQli5NN3pN2EGV6ax4piUfJWspkBM6SYBK+kdUda1xUIk0ITzcCDpne2Kf2/qjMvto+8+Ih0c6/Mf/7L6+Lbureutb11xa943ERakxXSSiYYmjx4tI6mdh87aLxE7b92pRjbacVUUAeK+WPGMAE5Y0nIKH5UHPf3QkZkFRkVo+plSEzAZSgAzAKUAOZA4cMijhRuQMpmnMvH4rZtM4ulGePM4tyyuW3xtDVos/QgZ7a9DFS/5yIpu0hLLiavu5i65iK76mILwm3AMmhV1N6DVkbNLAXCqqGTol8FHhT7ync8vXaGFGk4B875eufwFk5FRsYunT0/OZ6/kOTpZO7QP56v9rToic/swq58xOT+TE/6+I38/1y4vSy2E1qOnIGcf3VzzwZmVrIo1N51ehvcdtbO1PuPLPaJ2pKnn85q1gvqbOcExUbq9M1qp/3H3BMVOrdavNvjvnqnGPMnt5kSf1txaseXfQvP/bEb

Desktop (please complete the following information):

  • OS: openSUSE Leap 15.4 (Linux/x86_64).
  • Browser: Firefox 115.1.0esr (64 bits)

Additional context
I refreshed the page and even restarted the browser but it did not help. I also tried loading the exported link into a different browser [Chromium 116.0.5845.110 (openSUSE Build) stable (64 bits)] but that didn't help.
I only see this issue for my warrior. My feral druid and rogue aren't affected.

@jdelvare
Copy link
Author

The Gear line looks good to me, it does match the sum of Armor Penetration rating from my gear and gems. The incorrect value is the Total.

@jdelvare jdelvare changed the title Arpen total is incorrect Arpen total is incorrect for Arms Warrior Sep 1, 2023
@where-fore
Copy link
Contributor

The total is correct but the ui is a bit unclear: You are gaining 16% arp from Battle Stance + your set bonus, but that isn't showing up in any individual field. If you go to settings and change the stance to Berserker Stance, you'll lose the 16% arp and return to just the total of your gear.

@jdelvare jdelvare changed the title Arpen total is incorrect for Arms Warrior Arpen total is confusing for Warrior in Battle stance Sep 5, 2023
@jdelvare
Copy link
Author

jdelvare commented Sep 5, 2023

Thanks! I totally missed that Battle stance was increasing Armor Penetration in the first place. This explains why I hit the arpen soft cap earlier than I expected.

Given how the arpen bonus from Battle stance is implemented (assuming the simulator is right about it), a new line should be added for the Stance in the stats recap.

The same will have to be implemented for Melee Crit in Berserker stance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants