You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using storybook and viewing there source of a Doggo component the file is so large that the browser hangs mand becomes unresponsive processing the mark up.
To Reproduce
Steps to reproduce the behavior:
Using Doggo 0.5.0, setup storybook as per the docs.
Click the source button in the top right when viewing a component.
Wait, .. wait some more, browser is unresponsive.
Expected behavior
Just display the minimal and relevant code.
Code is organised into component module files rather than a single huge file.
Whilst this seems like the root cause may be a storybook issue, a single large file with all components is not ideal.
Please consider breaking out components into separate module files such as accordion.ex, button.ex etc
The text was updated successfully, but these errors were encountered:
Anyway, I don't think putting each function component into its own module is reasonable. Maybe phoenix_storybook could be updated to extract the relevant lines from the source code.
I'm planning to make the components customizable in a future version, which would have an impact on the source code display, though, so I don't think it's worth it to think about the module structure of doggo at this point.
Describe the bug
When using storybook and viewing there source of a Doggo component the file is so large that the browser hangs mand becomes unresponsive processing the mark up.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Whilst this seems like the root cause may be a storybook issue, a single large file with all components is not ideal.
Please consider breaking out components into separate module files such as accordion.ex, button.ex etc
The text was updated successfully, but these errors were encountered: