Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version param to wp plugin verify-checksums #106

Closed
1 task done
semseysandor opened this issue May 16, 2023 · 2 comments · Fixed by #108
Closed
1 task done

Add --version param to wp plugin verify-checksums #106

semseysandor opened this issue May 16, 2023 · 2 comments · Fixed by #108

Comments

@semseysandor
Copy link
Contributor

Feature Request

Describe your use case and the problem you are facing

For wp core verify-checksums the --version option is available to specify WP core version.
This is very useful in a deploy (update) process to check if the codebase is on the expected version.
If verify returns success, then skip download and/or report no change, if verification fails then download the right (usually newer) version. So it's possible to create an idempotent process.

It would be great to apply this logic to plugins also!

Describe the solution you'd like

Adding a --version option to plugin verify-checksums where we could directly set the version not just getting that from the plugin.
Of course, this would make sense only if a single plugin is provided, but this can be handled by ignoring --version if --all or multiple plugins are passed in.

Note: I'm happy to submit a PR.

@danielbachhuber
Copy link
Member

Sounds good 👍

We support multiple positional arguments and --version=<version> with wp plugin install, so we can follow that as prior art.

@danielbachhuber danielbachhuber changed the title Feature idea: add --version param to wp plugin verify-checksums Add --version param to wp plugin verify-checksums May 17, 2023
@semseysandor
Copy link
Contributor Author

semseysandor commented May 22, 2023

I was just wondering about the chances of installing (or verify) two different plugins that happens to have the same version. With --all, I believe, that chance gets close to zero... :)
But why not indeed? There can be a use-case, so don't limit ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants