Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept User instead of user ID only for reassign in user delete command #488

Closed
1 task done
ernilambar opened this issue Mar 12, 2024 · 3 comments
Closed
1 task done

Comments

@ernilambar
Copy link
Contributor

Feature Request

Describe your use case and the problem you are facing

Currently only User ID is accepted for --reassign in user delete command.

Describe the solution you'd like

Accept user login, user ID or user email.

@danielbachhuber
Copy link
Member

@ernilambar Can you share a bit more context for this request? I'm a bit hesitant about what you've proposed because:

  • It would technically be a breaking change.
  • We'd potentially want to make a similar change to wp post update --post_author=<id>, but I don't think it makes sense to.

@ernilambar
Copy link
Contributor Author

Please elaborate if I am not getting something but I dont think it would be breaking change as using ID are reassign value will continue to work like now. Along with ID we will accept login and email address as value like we do in other user commands. Under the hood, ID will be the actual value like WP core accepts.
We treat User ID, User Login and User Email as unique user identifier. So I think it would be good improvement to make those uniform in our all commands.

@danielbachhuber
Copy link
Member

@ernilambar The breaking change is that login and email would start being accepted, when they aren't currently accepted.

I think it's fine to make the change when it's the primary argument for the command. It's a bug that it was inconsistent in the first place. I don't think we should change these secondary arguments, though.

@danielbachhuber danielbachhuber closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants