Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace user-switching plugin in failing tests #387

Closed
2 tasks done
swissspidy opened this issue Nov 20, 2023 · 0 comments · Fixed by #418
Closed
2 tasks done

Replace user-switching plugin in failing tests #387

swissspidy opened this issue Nov 20, 2023 · 0 comments · Fixed by #418

Comments

@swissspidy
Copy link
Member

swissspidy commented Nov 20, 2023

Bug Report

Describe the current, buggy behavior

A few of the wp plugin * commands tests activate the User Switching plugin. The plugin recently bumped its minimum PHP version, which means those tests now fail.

Describe how other contributors can replicate this bug

Failing tests:

  • Scenario: Activate all when one plugin is hidden by "all_plugins" filter # features/plugin-activate.feature:37
  • Scenario: Return code is 1 when one or more plugin installations fail # features/plugin-install.feature:113
  • Scenario: Verify installed plugin activation # features/plugin-install.feature:222
  • Scenario: Plugin hidden by "all_plugins" filter # features/plugin.feature:577

Example run: https://github.com/wp-cli/extension-command/actions/runs/6914340823/job/18813033559?pr=386

Describe what you would expect as the correct outcome

Let's use another common plugin that still supports PHP 5.6 so that the tests pass again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant