Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring template files over from wp-cli/wp-cli #99

Closed
5 tasks done
schlessera opened this issue May 22, 2018 · 2 comments
Closed
5 tasks done

Bring template files over from wp-cli/wp-cli #99

schlessera opened this issue May 22, 2018 · 2 comments

Comments

@schlessera
Copy link
Member

schlessera commented May 22, 2018

The two Mustache template files required by this repository ( plugin-status.mustache & theme-status.mustache ) are still located in the wp-cli/wp-cli repository. This is an oversight from wp-cli/wp-cli#3728.

They should be moved over to this repository and then later removed from wp-cli/wp-cli once a new release for this package was tagged and required in wp-cli/wp-cli.

  • Copy plugin-status.mustache & theme-status.mustache into wp-cli/extension-command
  • Add plugin-status.mustache & theme-status.mustache to inclusion list in utils/make-phar.php
  • Tag a new release of wp-cli/extension-command with added files
  • Require that release or higher of wp-cli/extension-command in wp-cli/wp-cli
  • Remove plugin-status.mustache & theme-status.mustache from wp-cli/wp-cli
@wojsmol
Copy link
Contributor

wojsmol commented Jul 17, 2018

@schlessera If you point me in the right direction regarding 2 point then I can today send PR's.

@wojsmol
Copy link
Contributor

wojsmol commented Jul 20, 2018

@schlessera This was fixed by merging wp-cli/wp-cli#4854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants