Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

search-replace can be/is broken because of incorrect implode() #182

Closed
danielbachhuber opened this issue Jun 1, 2023 · 0 comments · Fixed by #183
Closed

search-replace can be/is broken because of incorrect implode() #182

danielbachhuber opened this issue Jun 1, 2023 · 0 comments · Fixed by #183
Labels
bug command:search-replace
Milestone
2.1.1

Comments

@danielbachhuber
Copy link
Member

danielbachhuber commented Jun 1, 2023 •
edited

Reported by @todeveni in Slack https://wordpress.slack.com/archives/C02RP4T41/p1685600917529129

i'm pretty sure that c238204 broke search&replace, due to spaces missing around AND in Search_Replace_Command.php#L615
getting these kind of errors when pulling production to local, which runs search&replaces for hostname etc:
LIKE BINARY '%_redacted_%'ANDmeta_id > 29482588ANDpost_id > 783226ANDmeta_key > '_oembed_a9c0bc1838b9cebff898495779df1b12'

@brandonpayton is looking into it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug command:search-replace
Projects
None yet
Milestone
2.1.1
Development

Successfully merging a pull request may close this issue.

Fix search-replace for tables with composite primary keys brandonpayton/search-replace-command
1 participant
@danielbachhuber